Try: Fix cover flex issue in the editor. #43413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Bug
|
It would be good to test the cover alignment options as well. |
|
Size Change: -25 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
mtias
reviewed
Aug 19, 2022
| @@ -47,10 +47,6 @@ | |||
| margin: 0; | |||
| } | |||
|
|
|||
| .block-editor-block-list__layout { | |||
There was a problem hiding this comment.
Removing editor specific code is great, let's make sure nothing is regressing though
jasmussen
requested review from
a team,
ockham and
ntsekouras
and removed request for
a team
tellthemachines
approved these changes
Aug 29, 2022
There was a problem hiding this comment.
Thanks for fixing this! I tested with several different configurations of nested blocks inside Cover and nothing unexpected is happening. For all Cover block inner wrapper purposes, the width property is duplicated here, so removing this line only changes places where it's affecting other blocks nested inside Cover.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #34909, props @alaczek for the code in #34909 (comment).
Flex containers inside a cover behaved strangely, only in the editor:
This PR removes the problematic code, which was introduced in #13822, fixing it:
It is unclear what the purpose of the previous code was, but it would be good to test with a variety of cover-specific patterns and content inside, to verify that nothing breaks as a result of this removal.
Testing Instructions
Sample code to test:
Instagram link should look good.