Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verse: Add margin support #43461

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Verse: Add margin support #43461

merged 1 commit into from
Aug 22, 2022

Conversation

ndiego
Copy link
Member

@ndiego ndiego commented Aug 21, 2022

Related:

What?

Add margin support to the Verse block.

Why?

To create consistency across blocks.

How?

Added the relevant block support in block.json

Testing Instructions

  1. Insert a new Verse block.
  2. Confirm the Dimension control panel allows you to add margin.
  3. Adding margin and configure.

Screenshots or screencast

verse-margin

@ndiego ndiego added [Type] Enhancement A suggestion for improvement. [Block] Verse Affects the Verse block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Aug 21, 2022
@ndiego ndiego self-assigned this Aug 21, 2022
@aaronrobertshaw aaronrobertshaw mentioned this pull request Aug 22, 2022
Open
aaronrobertshaw
aaronrobertshaw approved these changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@aaronrobertshaw aaronrobertshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🎉

Once the e2es are passing we should be able to land this.

For greater consistency with other blocks, we might also need to add box-sizing: border-box to this block's styles. Given this PR is only related to margin support, not padding, it doesn't need to happen here.

@ndiego
Copy link
Member Author

ndiego commented Aug 22, 2022

Thanks @aaronrobertshaw, I will look into the border-box issue separately. 🚢 ing

@ndiego ndiego merged commit a087af1 into WordPress:trunk Aug 22, 2022
@github-actions github-actions bot added this to the Gutenberg 14.0 milestone Aug 22, 2022
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronrobertshaw aaronrobertshaw aaronrobertshaw approved these changes

@ZebulanStanphill ZebulanStanphill ZebulanStanphill approved these changes

@ramonjd ramonjd Awaiting requested review from ramonjd

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@ryanwelcher ryanwelcher Awaiting requested review from ryanwelcher

@juanmaguitar juanmaguitar Awaiting requested review from juanmaguitar juanmaguitar is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

Assignees

@ndiego ndiego

Labels
[Block] Verse Affects the Verse block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Needs User Documentation Needs new user documentation [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 14.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ndiego @ZebulanStanphill @aaronrobertshaw @femkreations