-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query by name. #43850
Merged
Merged
Query by name. #43850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacedmonkey
added
Backport to WP Minor Release
Pull request that needs to be backported to a WordPress minor release
Backport from WordPress Core
Pull request that needs to be backported to a Gutenberg release from WordPress Core
labels
Sep 5, 2022
spacedmonkey
requested review from
adamziel,
peterwilsoncc,
adamsilverstein and
anton-vlasenko
September 5, 2022 10:34
peterwilsoncc
approved these changes
Sep 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to me.
- Both name and slug are indexed so which field to be consistent with makes no difference
- term uses an identical value,
wp_get_theme()->get_stylesheet()
for both name and slug so it doesn't appear that targetting one or the other is more technically correct.
Mamaduka
removed
the
Backport to WP Minor Release
Pull request that needs to be backported to a WordPress minor release
label
Nov 9, 2022
This was referenced Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Backport from WordPress Core
Pull request that needs to be backported to a Gutenberg release from WordPress Core
[Type] Performance
Related to performance efforts
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Use a query by name, for consistency, as other parts of code use name instead of slug. Save a database query.
Before
After
Why?
gutenberg/lib/compat/wordpress-6.1/block-template-utils.php
Lines 83 to 89 in 53da761
gutenberg/lib/compat/wordpress-6.1/block-template-utils.php
Lines 218 to 224 in 53da761
gutenberg/lib/compat/wordpress-6.1/block-template-utils.php
Lines 83 to 89 in 53da761
How?
Testing Instructions
Screenshots or screencast