FocalPointPicker: Convert to TypeScript #43872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +86 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
mirka
commented
Sep 5, 2022
| value: Parameters< UnitControlOnChangeCallback >[ 0 ], | ||
| axis: FocalPointAxis | ||
| ) => { | ||
| if ( value === undefined ) return; |
There was a problem hiding this comment.
Return early because TS doesn't want an undefined value passed to parseInt. The result is the same though, so shouldn't be considered a runtime change.
| const [ bounds, setBounds ] = useState( INITIAL_BOUNDS ); | ||
| const refUpdateBounds = useRef( () => { | ||
| if ( ! dragAreaRef.current ) return; |
There was a problem hiding this comment.
The rest of this function doesn't work if the ref is unset.
mirka
commented
Sep 5, 2022
Comment on lines
78
to
82
| | 'dragDirection' | ||
| | 'hideLabelFromVision' | ||
| | 'labelPosition' | ||
| | 'prefix' | ||
| | '__next36pxDefaultSize' |
There was a problem hiding this comment.
UnitControl was missing some props.
There was a problem hiding this comment.
We can probably wait for the NumberControl refactor to TypeScript to land first, and then rebase?
mirka
commented
Sep 5, 2022
| @@ -161,6 +235,7 @@ export default function FocalPointPicker( { | |||
|
|
|||
| return ( | |||
| <BaseControl | |||
| { ...restProps } | |||
There was a problem hiding this comment.
mirka
commented
Sep 5, 2022
mirka
force-pushed
the
ts-focal-point-picker
branch
from
409bf9f
to
7267149
Compare
ciampo
reviewed
Sep 6, 2022
Comment on lines
187
to
190
| // @ts-expect-error: TODO: Is this parseFloat necessary? | ||
| x: roundToTwoDecimalPlaces( parseFloat( resolvedValue.x ) ), | ||
| // @ts-expect-error: TODO: Is this parseFloat necessary? | ||
| y: roundToTwoDecimalPlaces( parseFloat( resolvedValue.y ) ), |
There was a problem hiding this comment.
It doesn't look like — let's remove it and see if we get any unexpected behavior from unit tests / manual regression testing.
Otherwise, @stokesman may also have some additional context ?
ciampo
approved these changes
Sep 7, 2022
There was a problem hiding this comment.
PR is looking good 🚀 only #43872 (comment) are #43872 (comment) still need to be addressed
Since this changes some of the UnitControl types, it definitely has some overlap with the NumberControl TypeScript refactor. Up to you about which PR you'd rather merge first, and which one you'd rather rebase + solve conflicts in
ciampo
reviewed
Sep 7, 2022
mirka
force-pushed
the
ts-focal-point-picker
branch
from
08a71e9
to
f709d34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #35744
In preparation for #38730
What?
Converts FocalPointPicker to TypeScript. To limit the scope of this PR, tests have not been touched.
Why?
Better docs and devex.
Testing Instructions
npm run storybook:devand see the FocalPointPicker stories in Docs view.✅ Type checks pass