Fix the horizontal block list drop indicator when dragging to the start #43944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
talldan
changed the title
|
Size Change: +478 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
kevin940726
reviewed
Sep 8, 2022
| @@ -18,7 +18,7 @@ test.describe( 'Draggable block', () => { | |||
| await admin.createNewPost(); | |||
| } ); | |||
|
|
|||
| test( 'can drag and drop to the top of a block list', async ( { | |||
| test( 'can drag and drop to the top of a vertical block list', async ( { | |||
There was a problem hiding this comment.
Note that changing the test's title will cause the reporter to open a new issue since it's the only id. I think it's okay though.
talldan
deleted the
fix/horizontal-drop-indicator-at-start-of-block-list
branch
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes this comment - #32880 (comment)
Why?
This wasn't working, as when dragging to the start of a block list
previousClientIdisundefined, and that's being used to get therootClientId. TherootClientIdis used to determine the block list orientation, and so the inserter was trying to use horizontal block list styles.How?
Use the
nextClientIdto get therootClientIdwhenpreviousClientIdisundefined.Testing Instructions
Screenshots or screencast
Before
After