Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typography block supports: call tear_down in tests and format PHP doc blocks #43968

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

ramonjd
Copy link
Member

@ramonjd ramonjd commented Sep 8, 2022

What?

  • Standardizing PHP doc comments for tests and new methods.
  • Replaced parent::set_up(); with parent::tear_down();.

Why?

I found some issues while backporting to Core: WordPress/wordpress-develop#3203

Testing Instructions

Tests should pass!
No typos! 🤞

Replaced parent::set_up(); with parent::tear_down();.
@ramonjd ramonjd added [Type] Developer Documentation Documentation for developers [Type] Code Quality Issues or PRs that relate to code quality [Feature] Typography Font and typography-related issues and PRs labels Sep 8, 2022
@ramonjd ramonjd self-assigned this Sep 8, 2022
@ramonjd ramonjd changed the title Typography: call tear_down in tests and format PHP doc blocks Typography block supports: call tear_down in tests and format PHP doc blocks Sep 8, 2022
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @ramonjd.

No typos! 🤞

We need Grammarly GitHub action for this 😄

@ramonjd ramonjd merged commit 40c1212 into trunk Sep 8, 2022
@ramonjd ramonjd deleted the update/typography-block-supports-formatting branch September 8, 2022 08:10
@github-actions github-actions bot added this to the Gutenberg 14.1 milestone Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Typography Font and typography-related issues and PRs [Type] Code Quality Issues or PRs that relate to code quality [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants