Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Title and Tagline: Add text decoration support #43972

Merged

Conversation

aaronrobertshaw
Copy link
Contributor

Related:

What?

Adds missing text-decoration block support to Site Title and Site Tagline blocks.

Why?

  • Improves consistency of our design tools across blocks.

How?

  • Opts into missing text-decoration typography support for Site Title and Site Tagline blocks.

Testing Instructions

  1. Edit a post, add both a Site Title and Site Tagline block.
  2. Select the Site Title block and ensure the text decoration control isn't displayed by default.
  3. Confirm text decoration for the Site Title block works in both the editor and frontend.
  4. Repeat steps 2-3 for the Site Tagline block.
  5. Confirm that you can set text decoration in the global styles for both Site Title and Site Tagline.
  6. Test that you can apply text decoration to both blocks via theme.json

Example theme.json snippet:

			"core/site-title": {
				"typography": {
					"textDecoration": "line-through"
				}
			},
			"core/site-tagline": {
				"typography": {
					"textDecoration": "line-through"
				}
			}

Screenshots or screencast

Screen.Recording.2022-09-08.at.7.35.59.pm.mp4

@aaronrobertshaw aaronrobertshaw added [Type] Enhancement A suggestion for improvement. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Block] Site Title Affects the Site Title Block [Block] Site Tagline Affects the Site Tagline Block [Feature] Typography Font and typography-related issues and PRs labels Sep 8, 2022
@aaronrobertshaw aaronrobertshaw self-assigned this Sep 8, 2022
Copy link
Contributor

@glendaviesnz glendaviesnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:

✅ Could add optional text decoration in post editor tools panel and changes were reflected in editor and frontend
✅ Could set text decoration in theme.json and reflected in editor and frontend

@aaronrobertshaw aaronrobertshaw merged commit f90eb72 into trunk Sep 8, 2022
@aaronrobertshaw aaronrobertshaw deleted the add/text-decoration-to-site-title-and-tagline branch September 8, 2022 23:32
@github-actions github-actions bot added this to the Gutenberg 14.1 milestone Sep 8, 2022
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Site Tagline Affects the Site Tagline Block [Block] Site Title Affects the Site Title Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs Needs User Documentation Needs new user documentation [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants