Components: Retire LIGHT_GRAY color object
#43994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the more meaningful `COLORS.ui.backgroundDisabled` in this case
|
Size Change: -45 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Sep 9, 2022
|
Not for this PR or even anything urgent, but just a general question. These components going back to their original G2 name were designed with this blue ("Blueberry" #3858E9) color in mind: The current blue is a classic WordPress blue: That classic WordPress blue is currently applied using a CSS variable across components:
Could we replace that hardcoded classic blue with the new Blueberry as a default for the components? So that consumers outside of the wp-admin context will get the correct blue? |
That is definitely something that we'd like to do as part of the work on theming. Ideally the component package would expose a few variables — in this specific case, something like "primary color" (or whatever name we find more appropriate). The package could use "blueberry blue" as the default value for that variable, but any consumer of the package would be able to override it (for example, Gutenberg could override it to whatever the admin color is). Having the package expose its own variables (instead of using gutenberg-specific variables) would help to decouple the package from the rest of the editor, and make it more reusable. How does that sound to y'all ? |
|
That sounds great! |
|
@jasmussen Do we want to update the default color scheme just for the components package? I looked into it and found that almost all I don't have a problem with either, just checking so we can take the correct approach! |
|
Thanks for following up. For now, mainly for the components package. |
23 tasks
|
Created #44116 to have a central place for theming conversations |
This was referenced Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #40392
What?
Replaces the following colors:
LIGHT_GRAY[ 800 ]#b5bcc2→GRAY[ 400 ]#ccccccLIGHT_GRAY[ 600 ]#d7dade→GRAY[ 300 ]#ddddddLIGHT_GRAY[ 400 ]#e8eaeb→GRAY[ 100 ]#f0f0f0LIGHT_GRAY[ 300 ]#edeff0→GRAY[ 100 ]#f0f0f0Affected components:
Why?
We want to consolidate our grays to the canonical gray scale in
@wordpress/base-styles.How?
Replace with the closest colors in the main GRAY object.
Testing Instructions
npm run storybook:devScreenshots