Components: Refactor withState to @testing-library/react
#44697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Enhancement
tyxla
requested review from
Mamaduka,
youknowriad,
mirka,
jsnajdr,
ciampo,
chad1008 and
ntsekouras
|
Size Change: 0 B Total Size: 1.27 MB ℹ️ View Unchanged
|
Closed
ntsekouras
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR refactors the tests of
withStateto use@testing-library/react's render instead ofreact-domrender. This addresses one of the changes needed to upgrade to React 18, as touched in #32765.Why?
This addresses one of the changes needed to upgrade to React 18, as touched in #32765.
How?
We're just using the
@testing-library/reactrender method and updating a few utilities, but another special.Testing Instructions
Verify tests still pass:
npm run test:unit packages/compose/src/higher-order/with-state/test/index.js