Writing flow: add Shift+Arrow when selection is 'full' #44727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
the
[Feature] Writing Flow
|
Nice, thank you for working on this. It might be good to rebase, as I recently merged the multi select style changes. As it is, I'm seeing a flickering issue on the cover block:
I also don't seem to be able to select upwards. I.e shift arrow up from a paragraph into an image. |
|
Size Change: +161 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
ellatrix
force-pushed
the
add/shift-arrow-full-selection
branch
from
cabae08
to
ddb5a4b
Compare
|
Flaky tests detected in 6fd8c8a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4532738423
|
ellatrix
force-pushed
the
add/shift-arrow-full-selection
branch
from
ddb5a4b
to
6fd8c8a
Compare
ellatrix
added
the
Backport to WP Minor Release
|
This is a pretty bad issue, I think it's maybe worth back porting to a minor release. |
mcsf
approved these changes
Mar 27, 2023
There was a problem hiding this comment.
Should we use store/private-selectors.js instead?
| export function __unstableIsBlockMergeable( state, clientId ) { | ||
| const blockName = getBlockName( state, clientId ); | ||
| const blockType = getBlockType( blockName ); | ||
| return !! blockType.merge; |
There was a problem hiding this comment.
The only way for blockType to be empty is if the selector is called with a bogus clientId, but it doesn't hurt to be defensive:
Suggested change
| return !! blockType.merge; | |
| return !! blockType?.merge; |
| @@ -199,8 +203,9 @@ function RichTextWrapper( | |||
| // is a parent block. | |||
There was a problem hiding this comment.
The comment here only mentions start and end, so it might need an update to reflect mergeability but also the block root condition.
Comment on lines
+237
to
+240
| scrollIntoView( | ||
| node.ownerDocument.getElementById( | ||
| `block-${ nextSelectionEndClientId }` | ||
| ), |
There was a problem hiding this comment.
Not a concern for this PR, but ideally we wouldn't be passing around DOM IDs here, right? "Scroll me into view" should be a "method" available for blocks in general.
tellthemachines
removed
the
Backport to WP Minor Release
|
Warning: Type of PR label error To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. |
|
Removing the minor release label because this hasn't been worked on for a few months so it's not a 6.3 regression 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
When selection is "full" (not partial), Shift+Arrow Up/Down should expand selection block by block.
Why?
Currently Shift+Arrow doesn't work at all.
How?
Testing Instructions
Select across two blocks that can't be merged, for example the list block and paragraph block. Try to expand selection with the keyboard (Shift+ArrowUp/Down).
Screenshots or screencast