-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site editor outlines: try subtle outlines on block hover #44775
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
the
[Feature] Site Editor
Related to the overarching Site Editor (formerly "full site editing")
label
Oct 7, 2022
Size Change: +61 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
jasmussen
force-pushed
the
try/site-editor-subtle-outlines
branch
from
November 7, 2022 14:13
eef0496
to
8f0363c
Compare
6 tasks
Closing for now, let's revisit later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Alternative to #44774. This PR does two things:
currentColor
versions. In being the same color as the text, and being thin, they are more subtle and less noisy.Before, hovering anything showed boundaries with a 1px border:
After, subtler hover styles:
Why?
This is a draft PR to find out whether the experience is better with keeping the hover outlines, but making them less noisy. See also #44774.
Testing Instructions
Open the site editor, hover various blocks. There should be text-color thin outlines when hovering blocks.