Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components: refactor TabPanel to pass exhaustive-deps #44935

Merged
merged 6 commits into from
Oct 25, 2022
Merged

Components: refactor TabPanel to pass exhaustive-deps #44935

merged 6 commits into from
Oct 25, 2022

Commits on Oct 25, 2022

  1. add missing deps to useEffect

    @chad1008
    chad1008 committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    ff5429f View commit details
    Browse the repository at this point in the history

  2. Components: update CHANGELOG

    @chad1008
    chad1008 committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    b91fc57 View commit details
    Browse the repository at this point in the history

  3. memoize and re-use selectedTab

    @chad1008
    chad1008 committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    c04d50e View commit details
    Browse the repository at this point in the history

  4. pass selectedTab?.mame instead of memoizing the full object

    @chad1008
    chad1008 committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    b3398ef View commit details
    Browse the repository at this point in the history

  5. fix tab selection bug causing test failures

    @chad1008
    chad1008 committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    9d63491 View commit details
    Browse the repository at this point in the history

  6. Update packages/components/src/tab-panel/index.tsx 

    Co-authored-by: Lena Morita <lena@jaguchi.com>
    @chad1008 @mirka
    chad1008 and mirka committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    cb108f4 View commit details
    Browse the repository at this point in the history