Fix splitting in the middle of a text block #453
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up to #409, this fixes an issue with splitting a text block in the middle of its content:
Instead, I'd expect that two Enter presses would be required to split the text block in the middle of its content, like when we edit at the end of a block.
The reason for this issue was that TinyMCE inserts a
<br data-mce-bogus=1>
element inside of our new second paragraph, and this causes thesplitIndex
to be-1
because we should really be looking for the parentp
element of thebr
. The solution I found is to walk the DOM tree until we find the currently selected top-level element of the block (in this case thep
element).