Add edit button to template parts, reusable blocks and navigation blocks #45465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Enhancement
|
|
|
Size Change: +480 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
|
Nice, seems useful! Here's a GIF showing template parts being locked and requiring an edit press:
As you can note, there are two small issues, firstly that I'm seing double edit buttons, if I click the first it disappears, and the second one works. Secondly that if I double click, or click really fast, I can "unlock". That seems like it could be a shortcut, but it was a bit unexpected. |
|
Thank you for trying this :) I appreciate it's a WIP but I think it's still worth pointing out a couple of missing elements that feel important to the general concept. After clicking 'Edit':
In regards to the double edit button, I think the one that invokes focus mode can move to the ellipsis, which would align with #45264. |
|
@youknowriad are you still planning to move this work forward? Checking in to see if we might need to get more development help here or if it's still on your list :) |
|
@annezazu I'm focused on another PR at the moment, so if we can get more development help on this, that would be good. Otherwise, I'll circle back to it a bit later. |
getdave
added
[Block] Navigation
|
Closing this for now, no time to focus on that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #43608
What?
This is not ready 100% but I wanted to share early. The idea is to add an "edit" button to template parts, reusable blocks and navigation blocks. By default when you click these blocks the "overlay" remains active unless you click the "edit" button.
The overlay is reset when you unselect the block or its children.
Why?
See the reasoning in the related issue.
How?
More details will be added later.
Testing Instructions
1- interact with reusable blocks or template parts and notice you need to first click the "edit" button in their toolbar.