Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try updated pattern category descriptions #45548

Closed
wants to merge 2 commits into from

Conversation

jasmussen
Copy link
Contributor

What?

Implements category descriptions suggested by @beafialho in #44501 (comment), as a starting point, and also includes some stubs for new proposed categories.

GIF showing the new category descriptions:

new descriptions

What's a good way to move forward with the future pattern categories? Do they need to be created in the pattern directory first? Do they require a core patch?

Perhaps more importantly, we probably want to remove the existing categories and replace them with the new categories, including the bundled patterns. What's the best way to do that?

Testing Instructions

Open the pattern inserter, then check each category for descriptions.

@jasmussen jasmussen added [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Feature] Pattern Directory The Pattern Directory, a place to find patterns labels Nov 4, 2022
@jasmussen jasmussen requested review from mcsf, youknowriad, ryelle and a team November 4, 2022 10:55
@jasmussen jasmussen self-assigned this Nov 4, 2022
@codesandbox
Copy link

codesandbox bot commented Nov 4, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

array(
'label' => _x( 'Featured', 'Block pattern category', 'gutenberg' ),
'label' => _x( 'Call to Action', 'Block pattern category', 'gutenberg' ),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all commented out for now, but I would expect them to replace all the existing categories.

@ntsekouras
Copy link
Contributor

Perhaps more importantly, we probably want to remove the existing categories and replace them with the new categories, including the bundled patterns. What's the best way to do that?

Can we split this in a different PR? I think we can go for now with the updated categories including a description.

Perhaps more importantly, we probably want to remove the existing categories and replace them with the new categories, including the bundled patterns. What's the best way to do that?

In the other PR if we replace them we should have a mapping of old and new categories.

@jasmussen
Copy link
Contributor Author

Can we split this in a different PR? I think we can go for now with the updated categories including a description.

Absolutely. I won't have time to pick up this PR again in the immediate future, but if you have bandwidth feel free to either push directly, or otherwise.

@ntsekouras
Copy link
Contributor

ntsekouras commented Nov 23, 2022

Absolutely. I won't have time to pick up this PR again in the immediate future, but if you have bandwidth feel free to either push directly, or otherwise

I'll create a new PR for the descriptions, so we can keep this for a while that has the new categories info. Sounds good?

@jasmussen
Copy link
Contributor Author

Thank you!

@jasmussen
Copy link
Contributor Author

@ntsekouras can I close this one, since you've extracted pieces?

@ntsekouras ntsekouras closed this Dec 8, 2022
@jasmussen
Copy link
Contributor Author

Thank you!

@youknowriad youknowriad deleted the try/pattern-category-updates branch December 8, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Pattern Directory The Pattern Directory, a place to find patterns [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants