[Pattern Directory]: Add categories endpoint #45749
Conversation
ntsekouras
added
Core REST API Task
|
|
ntsekouras
force-pushed
the
add/pattern-directory-categories-endpoint
branch
from
a1beb4b
to
ae38a3f
Compare
| public function test_prepare_pattern_category_for_response() { | ||
| $raw_categories = array( | ||
| (object) array( | ||
| 'id' => 3, | ||
| 'name' => 'Columns', | ||
| 'slug' => 'columns', | ||
| 'description' => 'A description', | ||
| ), | ||
| ); | ||
|
|
||
| $prepared_category = static::$controller->prepare_response_for_collection( | ||
| static::$controller->prepare_pattern_category_for_response( $raw_categories[0], new WP_REST_Request() ) | ||
| ); | ||
|
|
||
| $this->assertSame( | ||
| array( | ||
| 'id' => 3, | ||
| 'name' => 'Columns', | ||
| 'slug' => 'columns', | ||
| ), | ||
| $prepared_category | ||
| ); | ||
| } |
There was a problem hiding this comment.
Maybe we should use assertions similar to the ::prepare_item_for_response test - https://github.com/WordPress/wordpress-develop/blob/master/tests/phpunit/tests/rest-api/rest-pattern-directory-controller.php#L324-L334. What do you think?
There was a problem hiding this comment.
I don't think it makes any difference to load from a json file, since we're only checking if it preserves the props we want to and we don't make any request. That's why I also didn't use assertArrayNotHasKey, because it makes sense to test what to expect and not if just a key isn't there.
There was a problem hiding this comment.
I think that's okay. But core endpoints are probably expected to have the schema defined so we can add that assertion.
I don't have a strong opinion here; I'm just trying to make sure backports don't require many changes.
lib/compat/wordpress-6.2/class-gutenberg-rest-pattern-directory-controller-6-2.php
Show resolved
Hide resolved
lib/compat/wordpress-6.2/class-gutenberg-rest-pattern-directory-controller-6-2.php
Show resolved
Hide resolved
lib/compat/wordpress-6.2/class-gutenberg-rest-pattern-directory-controller-6-2.php
Outdated
Show resolved
Hide resolved
ntsekouras
force-pushed
the
add/pattern-directory-categories-endpoint
branch
from
5c43edf
to
f4d8e09
Compare
What?
This PR adds a new endpoint in pattern directory controller for categories. Extracted from #45237.
Testing Instructions
Test the API endpoint in a REST client (
/wp-json/wp/v2/pattern-directory/categories). It should match the pattern categories in pattern directory.