[Inserter]: Replace text in Reusable tab with an icon
#45851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Feature] Inserter
|
|
|
Size Change: +532 B (0%) Total Size: 1.3 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Nov 18, 2022
|
Pushed a small fix to use the sass variables for the button. I also fixed and slipstreamed a bug in the search input control which pushed the field right by 2px. Apparently the
|
|
@jasmussen I'm not sure about the gap to align the icon with the search icon, they seem unrelated elements. It feels the reusable tab should be consistent within the tab list first and go to the edge:
|
|
How's this then? Uses padding instead:
|
|
It not a huge deal, but it looks a bit awkward to me. The offset alignment works (just about) with the text tabs because they're all the same width. With the reusable tab the icon just looks mis-aligned 😕 I agree the original state of the PR is not perfect either though. One other idea: does the active indicator need to go to the edge? If it didn't we could have nice alignment and a square reusable tab:
|
|
Maybe I'm the odd one out, but this one feels the best right now:
Considering with the development of the library we might change things, I don't think it's worth making too many mods that will make the tab view inconsistent compared to the other tabbed views (post / block inspector; appearance / settings; etc). |
|
Updated to this. Happy to go with that, we can always tweak. |
|
Perhaps also one of the issues is that the gap between search and tabs is nonexistent, so it creates a visual coupling of all the elements. It feels like there should be some space between a focused tab and the search. |
|
Also not for this PR, as I don't want to add further work to it, but it'd be nice on the "reusable blocks" panel to add some text explaining what they are: "Saved blocks that can be reused across the site. Changes to them are synchronized." etc |
|
Thanks for tweaking the styles @jasmussen! I guess we can land with 🟢 CI, now. |
DaisyOlsen
added
[Type] Enhancement
This was referenced Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Alternative of #45847
If we go forward with this one, it will need some design input for the change of the width in the
reusabletabpanel button, if needed.Screenshots or screencast