Update which origins are queried for gutenberg_get_global_settings

[oandregal]

Part of #45171
Related #45969

What?

This PR makes sure the settings only query for the data they need.

Why?

We should not do operations that are unnecessary (such as database calls when there is no need).

How?

• By making the settings method to manage properly the origins.
• Adding a new condition for themes that do not have theme.json (there is no user data in this case).

Testing Instructions

Make sure automated tests pass.

[codesandbox]

  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

[oandregal]

@ramonjd @andrewserong I wanted to double-check if the logic makes sense to you (how base is being used and its relationship with themes with no theme.json).

[oandregal]

The only logic modified here is how we determine which $origin to query.

• adds a new condition for themes without theme.json
• make sure all is mapped to custom

[felixarntz]

@oandregal Approach LGTM, left a few comments with minor improvement suggestions.

[felixarntz]

LGTM, thanks for the updates!

[bph]

I attached a 'needs dev note' label, know that this is just an update of an existing feature. I tag it, so it can be surfaced again in two or three months when 6.2 release cycle comes to that point (that's just my personal estimate. I have no insight in any planning around 6.2 release cycle.) I will look through other PRs to get the bundle together.

@oandregal maybe, you have some bandwidth to write make dev notes while everything is fresh in your mind. There is also a label 'has-dev note' you can apply to any of the major PRs for this feature, once you have written a first draft. :-)

[oandregal]

This PR prevents user settings being queried for themes with no theme.json, data they don't have anyway. In terms of API/devexp/user experience this does not change anything, so I guess it does not need a devnote?

[andrewserong]

@ramonjd @andrewserong I wanted to double-check if the logic makes sense to you (how base is being used and its relationship with themes with no theme.json).

Thanks for the ping — the logic here makes sense to me, in that a theme without its own theme.json file should not result in a database query for the user styles, as there wouldn't be any. So it would still get the core, block and theme data, including presets, base layout styles, etc as required, but just skips that unnecessary query 👍

[anton-vlasenko]

@oandregal It seems I'm a bit late, but the testing instruction says:
Make sure automated tests pass.
I haven't found any unit tests for the gutenberg_get_global_settings() method.
I'm wondering how to test this PR, then. 🤔

[oandregal]

@anton-vlasenko this is certainly weird to test. There's no behavioral change for the user or the developer experience. The only change is that there's one less database query when the theme is classic (which, presumably, results in slightly better performance, data I haven't shared in this PR). Agreed, this function needs more tests.