Navigation: Remove "Hide more settings" from block settings dropdown #46077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Size Change: +57 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
This should be the other way around, I mean the block should have a way to opt out of "system" menu items. |
|
Closing in favour of #46675 (comment) |
|
I keep bringing this up, but why do we have this menu item at all, for any block? Can't we remove it entirely? |
|
Trying that here: #46709 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removes the "Hide more settings" from block settings dropdown in the Navigation Link and Navigation Submenu blocks.
Why?
These options don't make sense in these blocks when in the Navigation List View as they close the inspector controls.
How?
This approach doesn't work!
Testing Instructions