AlignmentMatrixControl: refactor to TypeScript #46162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chad1008
commented
Nov 29, 2022
chad1008
commented
Nov 29, 2022
|
Size Change: +15 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
chad1008
force-pushed
the
refactor/AlignmentMatrixControl-typescript
branch
from
e428e33
to
e34fc44
Compare
chad1008
commented
Dec 1, 2022
chad1008
commented
Dec 1, 2022
chad1008
commented
Dec 1, 2022
chad1008
changed the title
chad1008
force-pushed
the
refactor/AlignmentMatrixControl-typescript
branch
from
f811290
to
3e8947c
Compare
ciampo
reviewed
Dec 1, 2022
ciampo
reviewed
Dec 1, 2022
mirka
reviewed
Dec 2, 2022
Co-authored-by: Lena Morita <lena@jaguchi.com>
chad1008
force-pushed
the
refactor/AlignmentMatrixControl-typescript
branch
from
38caa18
to
1398c9a
Compare
mpkelly
pushed a commit
to mpkelly/gutenberg
that referenced
this pull request
Dec 7, 2022
Co-authored-by: Lena Morita <lena@jaguchi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Paired effort with @ciampo
Refactor the
AlignmentMatrixControlcomponent to TypeScriptPart of #35744
Why?
The refactor to TypeScript has many benefits (auto-generated docs, static linting and error prevention, better IDE experience). See #35744 for more details
How?
Followed the steps highlighted in the TypeScript migration guide.
Notable changes (or my own questions 😉) are noted with inline comments
Testing Instructions
Tests pass
Make sure that the component behaves as expected:
in the editor, by checking blocks such as Cover that offer an alignment option
Screenshots or screencast