Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Introduce class for sourcing block attributes from HTML #46345

Draft
wants to merge 19 commits into
base: trunk
Choose a base branch
from
Draft

WIP: Introduce class for sourcing block attributes from HTML #46345

wants to merge 19 commits into from

Commits on Jan 6, 2023

  1. WIP: Introduce class for sourcing block attributes from HTML

    @dmsnell
    dmsnell committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    ee934c3 View commit details
    Browse the repository at this point in the history

  2. Rearrange some functions and add support for presence of attribute in… 

    … selector
    @dmsnell
    dmsnell committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    5396d3b View commit details
    Browse the repository at this point in the history

  3. Add support for child and descendant selection within the HTML processor

    @dmsnell
    dmsnell committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    ac30fa4 View commit details
    Browse the repository at this point in the history

  4. Add additional test for child selection

    @dmsnell
    dmsnell committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    fdbb658 View commit details
    Browse the repository at this point in the history

  5. Add basic comment header to file

    @dmsnell
    dmsnell committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    97629ed View commit details
    Browse the repository at this point in the history

  6. Add more complete CSS selector parsing, add failing test case for nes… 

    …ted selector
    @dmsnell
    dmsnell committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    ebe3afa View commit details
    Browse the repository at this point in the history

  7. Restore tag processor pointer when getting content

    @dmsnell
    dmsnell committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    3c63e24 View commit details
    Browse the repository at this point in the history

  8. Make things worse, but lead towards making them better; GOTO

    @dmsnell
    dmsnell committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    3f7c419 View commit details
    Browse the repository at this point in the history

  9. Scribble notes

    @dmsnell
    dmsnell committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    02e3e5c View commit details
    Browse the repository at this point in the history

  10. Revise HTML navigation to use balanced_next with a depth tracker 

    Tests are broken because the attribute sourcer needs rework given this
different approach for navigating tags.
    @dmsnell
    dmsnell committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    ac7861d View commit details
    Browse the repository at this point in the history

  11. Remove bail depth since we can't track a negative-sized stack 

    For sibling navigation we have to continue
processing outside of balanced_next().
    @dmsnell
    dmsnell committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    4050282 View commit details
    Browse the repository at this point in the history

  12. Exit the enclosing tag in balanced_next, add tests

    @dmsnell
    dmsnell committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    c51a66e View commit details
    Browse the repository at this point in the history

  13. Getting closer

    @dmsnell
    dmsnell committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    89bb635 View commit details
    Browse the repository at this point in the history

  14. more tests

    @dmsnell
    dmsnell committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    e5cfd30 View commit details
    Browse the repository at this point in the history

  15. Closer still

    @dmsnell
    dmsnell committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    eb1367d View commit details
    Browse the repository at this point in the history

  16. Passing tests!

    @dmsnell
    dmsnell committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    30172ab View commit details
    Browse the repository at this point in the history

  17. Remove first draft select function

    @dmsnell
    dmsnell committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    f415bdb View commit details
    Browse the repository at this point in the history

  18. More test cases, a couple new failures

    @dmsnell
    dmsnell committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    6103139 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2023

  1. Only traverse children of non-closing or non-void elements.

    @dmsnell
    dmsnell committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    79c24bd View commit details
    Browse the repository at this point in the history