-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Base Styles: Extract long-content-fade to its own file so it can be imported and reused. #46485
Base Styles: Extract long-content-fade to its own file so it can be imported and reused. #46485
Conversation
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @vykes-mac! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, @vykes-mac ! Thanks for the detailed description 😊
Congratulations on your first merged pull request, @vykes-mac! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts: https://profiles.wordpress.org/me/profile/edit/ And if you don't have a WordPress.org account, you can create one on this page: https://login.wordpress.org/register Kudos! |
@vykes-mac checking back in to see if you're able to confirm your username on WordPress.org so that we can properly credit you within the WordPress 6.2 release later this month? |
Hi @jeffpaul my username on wordress.org is vykesmac. |
@vykes-mac wonderful, thank you! If you follow the steps in #46485 (comment), then next time this will happen automatically and I won't have to chase down this thread to remember/find your WordPress.org account... thanks! |
What?
Extract the
long-content-fade
mixin to it's own file.Why?
So that it can be easily reused by importing when needed. Whenever we need to use it we don't have to include the other mixins in the
_mixins.scss
which might cause collision in other codebases.How?
I'm moving the
long-content-fade
mixin from the_mixins.scss
file into it's own file so it can be imported and reused easily.Testing Instructions
_long-content-fade.scss
can be imported without build errors.- in html remove search block
.wp-block-search__inside-wrapper
- add class
Notice fading edges where the text overflows.
Testing Instructions for Keyboard
Screenshots or screencast