Global Styles: Fix Reset to defaults action by moving fills to be within context provider #46486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hin context provider
andrewserong
added
[Type] Regression
andrewserong
requested review from
youknowriad,
ramonjd,
scruffian and
ntsekouras
|
@youknowriad this change appears to fix the issue, just double-checking if there was a reason the component was moved outside the provider in the original PR? (Just want to make sure we don't accidentally cause any other issues via this fix) |
ramonjd
approved these changes
Dec 13, 2022
There was a problem hiding this comment.
This is working well for me.
✅ The reset global styles button works again (setUserConfig has the correct function signature)
✅ When changing to this branch, I can reset user global styles that I'd set using trunk
I can't see any issues with the site editor view mode, though @youknowriad might like to double check.
|
Size Change: +1 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
If there was a vote, my vote would be to merge this and get it checked over night. It blocks a pretty important feature. |
I was just thinking the same. It's an easy revert if it causes any issues. Thanks for the speedy review / collab on this one! |
andrewserong
deleted the
fix/global-styles-reset-to-defaults-not-working
branch
16 tasks
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes: #46484
Moves
<SidebarComplementaryAreaFills />which contains the global styles sidebar to be within the global styles provider.Kudos: @ramonjd for the idea!
Why?
Without being inside the provider, the
Reset to defaultsaction does not work.How?
<SidebarComplementaryAreaFills />to be within the global styles provider.Testing Instructions
Screenshots or screencast