Update OffCanvasEditor to use clientids tree #46541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
requested review from
draganescu,
getdave,
talldan,
MaggieCabrera and
ajlende
scruffian
force-pushed
the
update/offcanvaseditor-use-clientids-tree
branch
from
1a1cb4c to
2fa15f8
Compare
Co-authored-by: Daniel Richards <677833+talldan@users.noreply.github.com>
scruffian
force-pushed
the
update/offcanvaseditor-use-clientids-tree
branch
from
2fa15f8 to
497d5dc
Compare
|
Size Change: +21 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
scruffian
changed the title
getdave
approved these changes
Dec 14, 2022
scruffian
force-pushed
the
update/offcanvaseditor-use-clientids-tree
branch
from
d339a54 to
e434905
Compare
dmsnell
pushed a commit
that referenced
this pull request
Dec 15, 2022
* Navigation: Pass a tree of client ids instead of an array of blocks. Co-authored-by: Daniel Richards <677833+talldan@users.noreply.github.com> * Explain passing custom clientIDs Co-authored-by: Ben Dwyer <ben@bens-laptop.home> Co-authored-by: Daniel Richards <677833+talldan@users.noreply.github.com> Co-authored-by: Dave Smith <getdavemail@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The ListView component has a prop called
blockswhich receives an array of clientIds. We should pass the same thing to the OffCanvasEditor component.Why?
We hope that these two components will be merged, so they should receive the same props.
How?
Pass the clientId of the navigation block and then use that to select the clientIdTree from the store.
Testing Instructions
Testing Instructions for Keyboard
The same.