Site Editor: Memoize sidebar component #46604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Performance
|
Size Change: +7 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
Mamaduka
force-pushed
the
try/memo-site-editor-sidebar
branch
from
dc9e24c
to
710e24c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Small performance optimization for the Sidebar component to avoid rerendering when resizing the editor canvas.
Why?
I don't think we need to re-render the Sidebar every time the parent component re-renders. This can be expensive when a site has many templates.
The component is self-contained, I don't see any downsides with memoizing it.
Testing Instructions
Screenshots or screencast
Before
CleanShot.2022-12-16.at.11.26.12.mp4
After
CleanShot.2022-12-16.at.11.28.16.mp4