-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nav list alignment #46682
Merged
Merged
Fix nav list alignment #46682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajlende
added
[Type] Bug
An existing feature does not function as intended
[Block] Navigation
Affects the Navigation Block
CSS Styling
Related to editor and front end styles, CSS-specific issues.
labels
Dec 20, 2022
Size Change: -53 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
scruffian
reviewed
Dec 20, 2022
@@ -1,7 +1,7 @@ | |||
.offcanvas-editor__appender .block-editor-inserter__toggle { | |||
background-color: #1e1e1e; | |||
color: #fff; | |||
margin: $grid-unit-10 0 0 28px; | |||
margin: $grid-unit-10 0 0 24px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
margin: $grid-unit-10 0 0 24px; | |
margin: $grid-unit-10 0 0 $icon-size; |
scruffian
approved these changes
Dec 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Navigation
Affects the Navigation Block
CSS Styling
Related to editor and front end styles, CSS-specific issues.
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Aligns the block appender and cleans up some of the unused list view CSS.
Why?
Closes #46359
How?
synced-block
icon to useflex
since it's inside a flex container.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Before
After