[Block Library - Query Loop]: Show pattern titles in setup #46688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
Needs Design Feedback
ntsekouras
requested review from
Mamaduka,
jameskoster,
jasmussen,
ryanwelcher,
richtabor and
annezazu
|
Size Change: -844 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
|
Huge 👍 on this from me. I have found it confusing when introducing custom patterns to determine which is which especially when they are similar. |
|
As is this is a great improvement and the PR works as described! I have two pieces of feedback that shouldn't block this:
as.is.mov |
|
Seems fine to me 👍 |
ellatrix
approved these changes
Dec 21, 2022
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Recently there have been discussion about showing the pattern titles in various lists in the editor. Example is the list in inserter, where we added a tooltip.
Similarly there have been requests about showing the pattern titles in Query Loop setup, when we suggest patterns in
gridview. This PR shows the titles in thisgridview and also aligns better with the Pattern Explorer modal, which also shows the titles. I've also added hover/focus styles that are missed entirely currently.Testing instructions
Chooseto see the suggested patternsgridview and observe the new styles and the titlesBefore
Screen.Recording.2022-12-20.at.9.07.56.PM.mov
After
Screen.Recording.2022-12-20.at.8.36.18.PM.mov
Pattern Explorer (no changes were made here)
Screen.Recording.2022-12-20.at.8.38.29.PM.mov