Only display the modified post date if the post has been modified #46839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +10.1 kB (+1%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
carolinan
added
the
[Priority] Low
carolinan
removed
the
[Priority] Low
|
Flaky tests detected in 5de7629. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4342113468
|
aristath
approved these changes
Feb 8, 2023
There was a problem hiding this comment.
Thank you for working on this one @carolinan, this is a nice change!
Code looks good to me, and it does what it says. This looks OK to merge 👍
aristath
reviewed
Apr 19, 2023
Co-authored-by: Ari Stathopoulos <aristath@gmail.com>
bph
added
[Type] Bug
This was referenced Jul 13, 2023
|
This change made it impossible to use |
|
Wanted to leave feedback that this change caught me out on a new site this week. I only want to show one date on the post, but if the post is never updated, I don't see any date now. I also wanted to use the row block to add text before the date, but I can't customize it if it is published/updated. 
Conditional display plugins can help solve this, but it would be ideal to have a solution in core since it is likely widely used, especially with SEO trends towards displaying the lastest update date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The post date block has a setting that displays the modified date. When the setting is enabled, it displays the post date
if the post has not been modified.
This PR updates the block to only display the modified date if the setting is enabled and the post has been modified.
If the setting is enabled, but the post has not been modified, nothing is shown on the front.
It also adds a new CSS class to identify that the setting is enabled so that developers can style it differently.
Fixes #46645
Why?
Without this PR, a template that displays both the published date and the modified date could show two identical dates,
and there was no way to hide the modified date if the post was not modified.
How?
The PR compares the modified date and the post date and returns early if the time difference is a less than a minute.
Testing Instructions
Create a new post.
Add a post date block.
Wait a minute or two and add a second post date block. Enable the "Display last modified date" setting.
Save and view the front. Both blocks should show, with different dates.
Create a second new post.
Add a post date block. Enable the "Display last modified date" setting.
Save and view the front. If you were fast enough, the block should not show.
Go back to the editor, wait a minute and make a change to the post.
Save and view the front, confirm that the block shows.
Testing Instructions for Keyboard
Screenshots or screencast