Enable image size for featured images in templates #46848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolinan
added
the
[Block] Post Featured Image
|
Size Change: -61 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
carolinan
changed the title
aristath
approved these changes
Jan 18, 2023
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR enables the image size controls when the featured image placeholder is added to a block template that has no postId, for example the single post and single page templates.
Closes #45842
Why?
It was not possible to adjust the size of the featured image in the single post and page templates via the UI (unless you placed it in a query loop).
How?
The block had a conditional check for the post id, after which it rendered the placeholder without any extra block settings.
This condition was moved, and now renders the placeholder and the size settings.
Testing Instructions
Please test for possible regressions with featured images placed in the block editor and site editor, in and outside of query loops.
Testing Instructions for Keyboard
Screenshots or screencast
A recording of the single template in Twenty Twenty Three, with the image height, width and scale settings.
Screen.Recording.2023-01-03.at.08.25.44.mov