Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clear Apply and Cancel buttons to Link Control #46933

Merged
merged 16 commits into from
Jan 19, 2023
Merged

Add clear Apply and Cancel buttons to Link Control #46933

merged 16 commits into from
Jan 19, 2023

Commits on Jan 19, 2023

  1. Add initial Apply and Cancel buttons and refactor styles

    @getdave
    getdave committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    3ae5c55 View commit details
    Browse the repository at this point in the history

  2. Add improved cancellation logic

    @getdave
    getdave committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    0fe0199 View commit details
    Browse the repository at this point in the history

  3. Update tests

    @getdave
    getdave committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    1ec84b1 View commit details
    Browse the repository at this point in the history

  4. Add unit tests for Cancellation

    @getdave
    getdave committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    b3fda12 View commit details
    Browse the repository at this point in the history

  5. Fix Media flow tests

    @getdave
    getdave committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    dd21775 View commit details
    Browse the repository at this point in the history

  6. Add ability to supply callback to be triggered on cancelling

    @getdave
    getdave committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    ff3f638 View commit details
    Browse the repository at this point in the history

  7. Fix input padding and spinner positioning

    @getdave
    getdave committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    496baac View commit details
    Browse the repository at this point in the history

  8. Add test coverage to check optional onCancel is not called if undefined

    @getdave
    getdave committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    65a6749 View commit details
    Browse the repository at this point in the history

  9. Update button text string in e2e test

    @getdave
    getdave committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    760851e View commit details
    Browse the repository at this point in the history

  10. Fix tab stops in test

    @getdave
    getdave committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    e365cb4 View commit details
    Browse the repository at this point in the history

  11. Don't propgate the click back to the parent blocks

    @getdave
    Ben Dwyer authored and getdave committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    afec199 View commit details
    Browse the repository at this point in the history

  12. Fix more tab stops in tests

    @getdave
    getdave committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    0ec87aa View commit details
    Browse the repository at this point in the history

  13. Fix another test tab stops

    @getdave
    getdave committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    50feaff View commit details
    Browse the repository at this point in the history

  14. Fix snapshot missing open in new tab attributes

    @getdave
    getdave committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    c900773 View commit details
    Browse the repository at this point in the history

  15. reset the URL to undefined rather than an empty string so that the po… 

    …pover doesn't reopen
    Ben Dwyer committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    8cc0fd2 View commit details
    Browse the repository at this point in the history

  16. Ensure correctly resetting all “link” attributes to true default state

    @getdave
    getdave committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    ee46cf2 View commit details
    Browse the repository at this point in the history