Make the off-canvas navigation editor the default experience #46995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajlende
requested review from
draganescu,
scruffian,
getdave and
MaggieCabrera
ajlende
requested review from
spacedmonkey,
ellatrix and
tellthemachines
as code owners
|
Size Change: -116 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 0a58d83. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4015879754
|
|
Can we please wait with merging this until the accessibility review is completed? |
12 tasks
|
An accessibility review has been done (see #46939), and as a result the following issues have been created: #47007 Some of these have been closed and others (the harder/bigger ones) are still being worked on. This PR removes the experiment flag so that all users of the plugin will see it. This will help us to get more feedback so that we can get this stable with the hope of landing it in WordPress 6.2. I think it would be good to merge this now, so that we can get this feedback ASAP. There are a couple of factors that mitigate the risk:
|
I'm for it. Let's get this moving. |
scruffian
force-pushed
the
try/enable-off-canvas-nav-editor
branch
from
292af5c
to
8c908f5
Compare
draganescu
reviewed
Jan 25, 2023
| @@ -243,20 +218,46 @@ function NavigationMenuSelector( { | |||
| > | |||
| { __( 'Create new menu' ) } | |||
| </MenuItem> | |||
| { isOffCanvasNavigationEditorEnabled && ( | |||
| { process.env.IS_GUTENBERG_PLUGIN ? ( // Show this if the plugin is active - previously used isOffCanvasNavigationEditorEnabled | |||
There was a problem hiding this comment.
We only have this comment here but we use IS_GUTENBERG_PLUGIN in other places too. Isn't it self explanatory?
There was a problem hiding this comment.
The main reason is so that if we have to do a find/replace on this branch of the code in the future the places we need to change will be easier to find.
draganescu
previously requested changes
Jan 25, 2023
This happened in a different PR, so I don't think it should block this... |
getdave
approved these changes
Jan 25, 2023
Comment on lines
52
to
49
| { isOffCanvasNavigationEditorEnabled && parentNavBlockClientId && ( | ||
| { parentNavBlockClientId && ( |
There was a problem hiding this comment.
It does feel strange exposing this even though I believe it will only apply if there is a parent Nav block and thus won't appear for all blocks.
I feel we ought to have some indication that this is Nav block specific code inside the block editor package. A comment maybe?
There was a problem hiding this comment.
the condition does show it's nav block specific. it's also probably going away as soon as the overall effort to make these drill down panels easily configurable works out.
32 tasks
draganescu
dismissed
their stale review
I am not blocking this but I STILL think we should remove the manage menus before making this the default editing experience.
scruffian
force-pushed
the
try/enable-off-canvas-nav-editor
branch
from
3fe5ae0
to
025d050
Compare
juanmaguitar
added
[Type] Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removes the experimental flag on the off-canvas navigation editor and adds a new experimental option for the global navigation sidebar for the site editor since that piece is still experimental.
Why?
Closes #46938
How?
I went through each occurrence of where
window.__experimentalEnableOffCanvasNavigationEditorwas used and removed it and simplified the code where possible.The site editor global navigation sidebar was moved to its own experimental flag as that part is still experimental.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast