Add boolean contentStyle and clientId check to Column Edit InnerBlocks #47234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekblank
added
Mobile App - i.e. Android or iOS
|
Size Change: +858 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in e756d94. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3966976731
|
geriux
approved these changes
Jan 18, 2023
There was a problem hiding this comment.
LGTM! I agree including this change seems like the best option until we find out how to reproduce it or if there are other side effects from the React Native upgrade.
I tested this on both iOS and Android, I tried nesting Columns blocks and other blocks to check if there were no regressions, I also tested passing undefined as parentWidth and added some inner blocks and I found no issues. I also tested changing the alignments of the block.
4 tasks
|
@fluiddot @dcalhoun Given that this change was cherry-picked into the 1.87.2 release of Gutenberg Mobile, can this PR now be closed, or should we await the E2E test fixes? |
@derekblank Yes, we can close this PR as this change was merged via #47257. |
@derekblank I've just noticed that the commit that was cherry-picked in |
If I am not mistaken, the Closing this PR as it is no longer necessary. Feel free to reopen if needed. 🙇🏻 |
|
Oh, I overlooked that commit 🤦 , my bad. Yep, let's keep this PR closed, sorry for the noise 🙏 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds a boolean check to values passed to the
<InnerBlocks />component of block-library/src/column/edit.native.js.Related items:
Why?
This is an attempt to provide a fix for wordpress-mobile/gutenberg-mobile#5387, which investigates an issue reported via Sentry:
RCTFatalException: Unhandled JS Exception: TypeError: undefined is not an object (evaluating 'b[W].width').Currently, we have not found a way to replicate this issue in production. Based on the nature of the stack trace, it's possible that a width value may be
nullorundefinedwhen being passed to<InnerBlocks />, and is possibly an unintended side-effect of internal React Native changes made in the upgrade between 0.66.2 and 0.69.4. Until a more specific resolution can be found, this fix is proposed as the user impact rate of this crash is currently 0.098%. The intent is that the boolean checks may preventnullorundefinedvalues from being passed to other components, and if that is true, we would see the user impact threshold decrease in Sentry as evidence.How?
Checks for both the value of
contentStyleandcontentStyle[ clientId ]before passing theparentWidthvalue to the component:Testing Instructions