Site Hub: Remove the aria-label from the Edit button #47343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -6 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in b1e33db. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3983958416
|
|
Note that this change is mutually exclusive with #47142 since if the Edit button will only show an icon, the aria-label needs to be kept. |
|
Looks good to me! Aside: it is worth noting that on small screens the button text changes to 'View Editor':
I'm not sure what's the reasoning for this. 'Edit' and 'View' are two pretty different logical concepts. Either the button action should always be 'Edit' or always be 'View Editor'. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removes the aria-label from the Edit button that is located in the top part of the screen in browse mode (When you first open the Site Editor).
Closes #47335.
Why?
The aria-label (Open the editor) and button text (Edit) did not match. For details please see the issue.
Testing Instructions
Testing Instructions for screen reader users
Screenshots or screencast
Before:
After:
