Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NumberControl: Clarify deprecation message about hideHTMLArrows prop #47370

Merged
merged 3 commits into from
Jan 25, 2023
Merged

NumberControl: Clarify deprecation message about hideHTMLArrows prop #47370

merged 3 commits into from
Jan 25, 2023

Conversation

t-hamano
Copy link
Contributor

What?

This PR clarifies the message about the hideHTMLArrows prop of the NumberControl component, which is marked as deprecated.

Before

before

After

after

Why?

Developers will see this message in the next major WordPress release, as this property is marked as deprecated in WordPress 6.2. However, it is difficult to tell at a glance which component the property relates to. Maybe some developers can predict components from the word UnforwardedNumberControl, though.

How?

I included the component name in the message, as we did with deprecated messages such as UnitControl and Button components.

@t-hamano t-hamano self-assigned this Jan 24, 2023
@t-hamano t-hamano added [Type] Code Quality Issues or PRs that relate to code quality [Package] Components /packages/components Developer Experience Ideas about improving block and theme developer experience labels Jan 24, 2023
@t-hamano t-hamano requested review from mirka and ciampo January 24, 2023 04:31
mirka
mirka approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@mirka mirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thank you!

packages/components/src/number-control/index.tsx Outdated Show resolved Hide resolved
@t-hamano @mirka
Update packages/components/src/number-control/index.tsx
93eb91b 
Co-authored-by: Lena Morita <lena@jaguchi.com>
@github-actions
Copy link

Flaky tests detected in 93eb91b.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4007654884
📝 Reported issues:

@t-hamano t-hamano merged commit 1cb9ec5 into trunk Jan 25, 2023
@t-hamano t-hamano deleted the quality/number-control-deprecated-message branch January 25, 2023 16:40
@github-actions github-actions bot added this to the Gutenberg 15.1 milestone Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirka mirka mirka approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@ciampo ciampo Awaiting requested review from ciampo

Assignees

@t-hamano t-hamano

Labels
Developer Experience Ideas about improving block and theme developer experience [Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 15.1
Development

Successfully merging this pull request may close these issues.
2 participants
@t-hamano @mirka