Fix inline block declaration anti-pattern in global styles UI #47374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
|
Size Change: -1 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes an anti-pattern - declaring a react component inline within another react component.
Why?
React's reconciler doesn't know how to handle this. On every render it'll think this is a new component, and unmount/remount the associated elements in the DOM.
This can be bad for performance and cause issues like focus loss. This particular piece of UI doesn't have much interactivity, so it's probably not an issue here, but worth fixing it now as it may change in the future.
How?
Move the component declaration to the parent module scope.
The component was previously closing over the
parentMenuvariable, so this is now passed as a prop.Testing Instructions