-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add new typography options for figcaption on image block [#34643] #47424
Conversation
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @hbhalodia! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
Hi @Mamaduka, I have added only for the font Size and a selector. Can you please review the PR. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The codewise looks good.
@richtabor, I would appreciate 2nd opinion, if having a Typography option on Image block makes sense.
cc @scruffian.
No, I don't think it does. We do have the ability to style captions within theme.json — that should probably be exposed within Global Styles in the Elements panel instead.
|
Can you give a context when this would be useful? |
The idea is to be able to set a different caption font size on a per-image basis. I don't think we should have font size for captions on individual image blocks — but rather expose figcaption element styling within Global Styles. |
I'll close the PR. Thanks for contributing, @hbhalodia! |
What?
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
ImageBlockCaption.webm