Lock the experimental clearBlockSelection editor setting #47591
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Package] Block editor
|
Size Change: +4 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
14 tasks
|
If I understand correctly this settings is not used by first party code and is meant to be used by third party ones. By locking it they are not going to be able to update this setting. |
It's true. I don't think it'd be impossible to update the setting, but maybe too difficult. It'd also be hard to support in a backwards compatible way (supporting both versions of Gutenberg that use lock and those that don't) I guess the best thing is to stabilize it. I'll put together another PR (#47627). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
See #47196
The
__experimentalClearBlockSelectioneditor setting was introduced in a contributor PR - #44517.It's unclear whether this is ready for stabilization. New experimental PRs should use the locking system introduced in #46131 in advance of WordPress 6.2, so I'm changing the implementation in this PR.
It's also worth noting that there are some proposed changes in #40450 that might conflict with the idea of this setting.
How?
__experimentalprefix from the settingprivateSettingsarray.Testing Instructions
There should be no change in the behavior in
trunk.