Add basic tsconfig.json validation #47595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
requested review from
ajitbohra,
gziolo,
ntwb,
nerrad and
ellatrix
as code owners
|
Size Change: 0 B Total Size: 1.31 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 8410fb0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4081307057
|
ciampo
approved these changes
Feb 2, 2023
|
Thanks @ciampo!
Realised that this is really easy to configure via the |
|
Just a thought: I wonder if this is achievable with eslint? 😅 |
|
Please elaborate! I thought it only checked JavaScript? |
Let's cc. @gziolo who is my go-to for such things 😀 but to be honest I'm pretty confident in this so will just merge. If something breaks can fix or revert. |
adamziel
reviewed
Feb 3, 2023
ntsekouras
added
the
Backport to WP 6.7 Beta/RC
ntsekouras
pushed a commit
that referenced
this pull request
Feb 9, 2023
* Add validate-tsconfig script * Fix lint errors * Add tsconfig linting to lint-staged
|
Cherry-picked this PR to the wp/6.2 branch. |
ntsekouras
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds a very basic script to validate that each package's
tsconfig.jsoncontains references for any@wordpress/dependency that has typings.For example if
deprecatedappears inblock-editor'spackage.json, and bothblock-editoranddeprecatedhave atsconfig.json, thendeprecatedmust appear inblock-editor'stsconfig.json.Why?
I was working on #47229 and it took me a billion years to figure out that a "Missing type declaration" error was to do with a missing reference in a completely unrelated package.
How?
Adds a new
binscript similar in nature to the existingvalidate-package-lock.jsscript. It is ran as part ofnpm run lint. I think this means it's ran in CI but not ongit commit. Maybe that's something we can improve. I figure anything is better than nothing, though.I also fixed all missing references in the project.
Testing Instructions
npm run lint:tsconfig