PanelBody: Convert to TypeScript #47702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brookewp
commented
Feb 2, 2023
|
PS — now that #47259 is merged, you should be able to rebase on top of |
brookewp
force-pushed
the
ts-panelbody
branch
2 times, most recently
from
15158a1
to
eea90d1
Compare
|
Size Change: -9 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in ecbb8fa. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4317279213
|
brookewp
force-pushed
the
ts-panelbody
branch
from
13cca82
to
948ee4a
Compare
tyxla
reviewed
Feb 8, 2023
There was a problem hiding this comment.
Thanks for working on this @brookewp!
I've left a comment about a missing prop that will cause the tests to fail.
The other reason for the failure is the renamed test file - the old snapshot for test/body.js can be removed and to regenerate a new snapshot for the body.tsx file, you could npm run test:unit:watch packages/components/src/panel and once tests finish, type u to recreate the snapshots.
Let me know if that helps!
brookewp
force-pushed
the
ts-panelbody
branch
from
948ee4a
to
db1449e
Compare
ciampo
reviewed
Feb 13, 2023
There was a problem hiding this comment.
Great job so far, @brookewp ! This is definitely a tricky task, and I appreciate you working on it 👏
I left some detailed comments to highlight a few changes while explaining the thought process that I'd normally go through when working on such a task.
For now, I've mostly payed attention to the code changes. Once the code looks good, we can take a look also at the JSDocs for each prop (and their equivalent in the README).
Finally, could you also add a CHANGELOG entry ?
Thank you!
brookewp
force-pushed
the
ts-panelbody
branch
from
db1449e
to
ddffacb
Compare
ciampo
reviewed
Feb 15, 2023
ciampo
reviewed
Feb 16, 2023
brookewp
force-pushed
the
ts-panelbody
branch
from
2a3b658
to
96b518a
Compare
brookewp
force-pushed
the
ts-panelbody
branch
from
96b518a
to
df23167
Compare
ciampo
approved these changes
Mar 1, 2023
There was a problem hiding this comment.
Thank you for working on this PR, @brookewp !
The code changes LGTM 🚀
Feel free to merge this PR once all remaining feedback Including Chad's) has been addressed (it should all be quite minor).
Congratulations on completing your first TypeScript refactor 🎉
|
🚀 |
|
Thank you for the fantastic work here, @brookewp 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Refactor the
PanelBodycomponent to TypeScript following Panel: #47259Why?
Part of the refactor to Typescript: #35744
How?
Followed the steps in the TypeScript migration guide
Testing Instructions
run npm storybook:devand check the docs forPanelBody