Copy failing WP_HTML_Tag_Processor_Bookmark_Test tests from Core

[noisysocks]

PHP unit tests are failing on trunk:

https://github.com/WordPress/gutenberg/actions/runs/4080664124/jobs/7033415868

I noticed the two failing tag processor tests were different to what's in Core. Assumedly something changed in the implementation during the process of committing. To fix, I simply replaced the implementation of these failing tests with the one that's in Core.

[andrewserong]

This change LGTM since it'll be testing against the core version... however, should we also update this line: https://github.com/WordPress/gutenberg/blob/trunk/lib/experimental/html/class-wp-html-tag-processor.php#L602 to use the _doing_it_wrong line from core, for consistency? (Without this change, PHP tests might fail locally for folks if they're testing against WP 6.1)

			_doing_it_wrong(
				__METHOD__,
				__( 'Too many bookmarks: cannot create any more.' ),
				'6.2.0'
			);
			return false;

In a follow-up it'd be good to switch the GB tests over to a Gutenberg prefixed or suffixed version of the tag class, if we can.

[andrewserong]

Thanks for updating! Just confirmed that the PHP tests are passing locally, and smoke tested the tag processor is outputting classnames correctly on the site frontend for the position and layout supports.

Assuming the Github Actions still pass, this LGTM, thanks for the quick PR! ✨

[noisysocks]

Ah yeah good point. Done.

I'll leave it up to someone else (@dmsnell, probably) to work out what to do with the WP_HTML_Tag_Processor that's in Gutenberg now that there's on in Core¹ Just focused on a minimal change here to get tests passing for now.

Footnotes

1. Gutenberg_HTML_Tag_Processor makes sense if we're planning on adding lots of new experimental features to the tag processor. If not then probably best to just make future updates directly in Core. ↩

[github-actions]

Flaky tests detected in ee45b79.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4080944147
📝 Reported issues:

• [Flaky Test] results in two remaining blocks and positions the caret at the end of the second block #39805 in specs/editor/various/block-deletion.test.js

[dmsnell]

Thanks all. The current plan is simply to move the the Core version of the tag processor into lib/compact and then remove the unit tests. I'll be working on this over the next few days.