OffCanvasEditor: Only allow some blocks to be converted to submenus #47974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
[Block] Navigation
|
Size Change: +52 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 05666e2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4173111874
|
draganescu
approved these changes
Feb 13, 2023
|
I restarted some of the tests. |
getdave
reviewed
Feb 13, 2023
packages/block-editor/src/components/off-canvas-editor/leaf-more-menu.js
Outdated
Show resolved
Hide resolved
getdave
reviewed
Feb 13, 2023
packages/block-editor/src/components/off-canvas-editor/leaf-more-menu.js
Outdated
Show resolved
Hide resolved
getdave
reviewed
Feb 13, 2023
packages/block-editor/src/components/off-canvas-editor/leaf-more-menu.js
Outdated
Show resolved
Hide resolved
scruffian
added
the
Backport to WP 6.7 Beta/RC
…re-menu.js Co-authored-by: Dave Smith <getdavemail@gmail.com>
scruffian
force-pushed
the
update/blocks-that-can-be-submenus
branch
from
449e708
to
05666e2
Compare
DaisyOlsen
added
[Type] Bug
ntsekouras
pushed a commit
that referenced
this pull request
Feb 21, 2023
…47974) * OffCanvasEditor: Only allow some blocks to be converted to submenus * make the option disabled * Update packages/block-editor/src/components/off-canvas-editor/leaf-more-menu.js Co-authored-by: Dave Smith <getdavemail@gmail.com> --------- Co-authored-by: Dave Smith <getdavemail@gmail.com>
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: 6786a14 |
ntsekouras
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The "Add submenu item" option should only be available for navigation link and navigation submenu blocks. Fixes #47971
Why?
It's not possible to convert other blocks to navigation submenus.
How?
Adds an allow list of blocks that can be converted.
Testing Instructions
Screenshots or screencast