Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish code editor #4803

Merged
merged 2 commits into from
Feb 1, 2018
Merged

Polish code editor #4803

merged 2 commits into from
Feb 1, 2018

Conversation

jasmussen
Copy link
Contributor

We've neglected this piece for a while, because we know there will be likely be some CodeMirror involved.

But that's no reason not to make small improvements in the meantime. This PR:

  • Removes the dummy quicktag buttons that did nothing.
  • Shows outlines around the title and body always.
  • Fix a typo that caused the textarea to be small.
  • Unify the paddings.
  • Relax the lineheight.

Screenshots:

screen shot 2018-02-01 at 10 50 42

screen shot 2018-02-01 at 10 50 56

screen shot 2018-02-01 at 10 51 14

We've neglected this piece for a while, because we know there will be likely be some CodeMirror involved.

But that's no reason not to make small improvements in the meantime. This PR:

- Removes the dummy quicktag buttons that did nothing.
- Shows outlines around the title and body always.
- Fix a typo that caused the textarea to be small.
- Unify the paddings.
- Relax the lineheight.
@jasmussen jasmussen requested a review from youknowriad February 1, 2018 09:53
@jasmussen jasmussen self-assigned this Feb 1, 2018
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should try to use the same width and padding/margin as the visual editor, that way when we switch between modes, the title would keep its position?

Also, wondering about the reason to always show the border instead of showing it on focus for instance?

@jasmussen
Copy link
Contributor Author

Both good questions.

Do you think we should try to use the same width and padding/margin as the visual editor, that way when we switch between modes, the title would keep its position?

Yes. But right now the code editor uses some hacks center it, those hacks are related to the full-wide tweaks. But it's a tangle of code that I'm actually going to try and look at now, separately. Once it's good in the main editor, I'll port the width to the code editor, but I'd prefer doing it later, if it's okay with you.

Also, wondering about the reason to always show the border instead of showing it on focus for instance?

The visual editor is not a form, it's more of a canvas. But the code editor is more like a form, which makes it feel more right to show the outlines all the time.

Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants