Navigation: Wrap the dependent functions in useCallback #48195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +23 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in baf23cc. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4231090127
|
draganescu
approved these changes
Feb 20, 2023
scruffian
force-pushed
the
fix/changing-deps
branch
from
c3ca257
to
baf23cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In #48066 we added all the necessary dependencies to the useEffects in the navigation block. Three of these dependencies (handleUpdateMenu, hideNavigationMenuStatusNotice, showNavigationMenuStatusNotice) were functions, which get redefined whenever the component renders. This means we got stuck in a loop where there useEffect would keep firing.
To avoid this we need to wrap these function in
useCallbackwhich will cache the function until the parameters change. I'm not sure if I have specified the correct dependencies for theuseCallbackfunctions I have added.Testing Instructions