Widget Editor: Fix a problem with 'Move to Widget Area' button not working #48233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
t-hamano
requested review from
talldan,
noisysocks,
tellthemachines,
adamziel and
kevin940726
as code owners
|
Size Change: -2 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 5811f6e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4229253281
|
draganescu
approved these changes
Feb 20, 2023
|
@ntsekouras |
t-hamano
added
the
Backport to WP 6.7 Beta/RC
ntsekouras
pushed a commit
that referenced
this pull request
Feb 21, 2023
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: f949698 |
ntsekouras
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48113
What?
This PR fixes a problem with 'Move to Widget Area' button not working in the widget editor.
Why?
I have discovered that the root client ID (
sourceRootClientId) for the widget area from which I'm moving isnull. In #30826, when this feature was implemented,yieldwas used to get the route ID of the source of the move. Perhaps the parentheses were not removed when they were refactored into theregistry. The second argument of the currentgetBlockRootClientIdaccepts only a single clientId.Screenshots or screencast
Make sure that moving blocks between widgets works correctly.
3a851aefd28468d756ec24f272d6fa37.mp4