Add typescript-eslint rules with type informations to e2e tests #48267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
[Type] Bug
|
Size Change: +1.01 kB (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 5cebb3a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4229560930
|
kevin940726
force-pushed
the
add/typescript-eslint-type-checking
branch
from
a12672a
to
7e13955
Compare
t-hamano
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Enable the following three rules to Playwright e2e tests:
@typescript-eslint/await-thenable@typescript-eslint/no-floating-promises@typescript-eslint/no-misused-promisesAnd also fixes the reported errors.
Why?
Playwright is well-typed, we can enable some additional eslint rules to help us catch some bugs.
How?
I originally tried enabling the rule for the whole project, but it's taking too long to process the monorepo. I think it's related to this documented known issue on the website.
I also tried extending
plugin:@typescript-eslint/recommended-requiring-type-checking, but some rules don't work great with pure js files.Testing Instructions
npm run lint:js # or npm run lint:js -- test/e2eCI should pass.
Screenshots