Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Enable access to block settings within UBE #48435

Merged
merged 10 commits into from
Mar 1, 2023

Commits on Feb 24, 2023

  1. fix: Enable access to block settings within UBE

    The "Show more settings" menu item is no longer included in the block
    toolbar after #46709 merged. Rather than relying upon that menu item,
    this conditionally displays the sidebar toggle button whenever a block
    is selected.
    dcalhoun committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    5bd1081 View commit details
    Browse the repository at this point in the history
  2. fix: Disable white space stripping that breaks nested CSS selectors

    CSS selectors rely upon a single white space between selectors to
    represent an ancestor relationship. Globally removing white space in the
    stylesheet breaks this functionality, as it transforms the selector to
    target a single element with all the selectors.
    
    The white space stripping should likely be replaced with a proper CSS
    minification long term.
    dcalhoun committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    fcfb7d4 View commit details
    Browse the repository at this point in the history
  3. fix: Hide block actions unrelated to editing a single block

    Hide the entire "block settings" drop-down menu now that we no longer
    rely upon it to access the "Show more settings" menu option that was
    removed entirely.
    dcalhoun committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    a5b08b1 View commit details
    Browse the repository at this point in the history
  4. refactor: Relocate script toggling block settings visibility

    This relates more to editor behavior than the post content.
    dcalhoun committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    25dddd0 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2023

  1. fix: Apply styles and script to editor canvas iframe

    The editor canvas now relies upon an iframe. It is not possible to style
    elements within an iframe from the parent context. This copies the
    styles from the parent conext to the iframe.
    
    Additionally, the logic selecting the first block also failed due to the
    block not existing when it was invoked. This relocates that logic until
    after the iframe is ready.
    dcalhoun committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    ea8d18e View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2023

  1. fix: Expand conditional checks for partial DOM trees

    On Android, there were times where the iframe was present, but the
    nested window was not yet ready.
    dcalhoun committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    7c1773b View commit details
    Browse the repository at this point in the history
  2. refactor: Rename for brevity

    dcalhoun committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    b7f10f5 View commit details
    Browse the repository at this point in the history
  3. fix: Avoid React removing appended iframe styles

    Append the styles to the `document` element, as React will remove the
    mutation to the `head` element.
    dcalhoun committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    a7eb9a2 View commit details
    Browse the repository at this point in the history
  4. Merge branch 'trunk' of github.com:WordPress/gutenberg into fix/enabl…

    …e-access-to-block-settings-within-ube
    dcalhoun committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    752a659 View commit details
    Browse the repository at this point in the history
  5. docs: Add change log entry

    dcalhoun committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    7233623 View commit details
    Browse the repository at this point in the history