Add support for :link and :any-link in theme.json
#48634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
the
Backport from WordPress Core
oandregal
requested review from
peterwilsoncc,
audrasjb,
hellofromtonya,
MaggieCabrera,
scruffian,
mikachan,
getdave,
ramonjd,
madhusudhand and
adamziel
|
cc people that had been involved in this work in core: cc @whaze @peterwilsoncc @mukeshpanchal27 @costdev @audrasjb As I mentioned in the core ticket, this sort of changes need to be backported to Gutenberg (preferably, developed in Gutenberg so they can be widely tested before landing in core). Also people who added support for pseudo-elements in links #41786 @getdave @adamziel @madhusudhand @ramonjd @scruffian and support for the same in buttons #43088 @MaggieCabrera @scruffian @mikachan I presume this is a straightforward backport from core, but I have not been involved in any of the efforts mentioned above, so I'd rather double-check. |
|
Hi, this changeset looks good to me, perfect 👍 |
peterwilsoncc
approved these changes
Mar 1, 2023
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Backports WordPress/wordpress-develop#3631 that adds support for
:linkand:any-linkpseudo-elements intheme.json. Core ticket https://core.trac.wordpress.org/ticket/57053Why?
Gutenberg and WordPress core classes need to be in sync.
How?
By backporting the changes done to the corresponding core class.
Testing Instructions
None provided in the original PR.