Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo: use WP_Theme_JSON_Gutenberg instead of WP_Theme_JSON class name #48648

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Fix typo: use WP_Theme_JSON_Gutenberg instead of WP_Theme_JSON class name #48648

merged 1 commit into from
Mar 1, 2023

Conversation

oandregal
Copy link
Member

Follow-up to #48644

What

This fixes a typo in the class name.

Why

Gutenberg code should use the WP_Theme_JSON_Gutenberg class instead of the WP_Theme_JSON class defined by core.

Testing

No need.

@oandregal oandregal self-assigned this Mar 1, 2023
@oandregal oandregal added [Type] Bug An existing feature does not function as intended Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Mar 1, 2023
@oandregal oandregal mentioned this pull request Mar 1, 2023
Merged
@github-actions
Copy link

github-actions bot commented Mar 1, 2023

Flaky tests detected in 6012a2b.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4305862863
📝 Reported issues:

@oandregal oandregal merged commit c04c501 into trunk Mar 1, 2023
@oandregal oandregal deleted the fix/typo-class-name branch March 1, 2023 17:41
@oandregal oandregal changed the title Fix typo: use the gutenberg class name Fix typo: use WP_Theme_JSON_Gutenberg instead of WP_Theme_JsON class name Mar 1, 2023
@oandregal oandregal changed the title Fix typo: use WP_Theme_JSON_Gutenberg instead of WP_Theme_JsON class name Fix typo: use WP_Theme_JSON_Gutenberg instead of WP_Theme_JSON class name Mar 1, 2023
@github-actions github-actions bot added this to the Gutenberg 15.4 milestone Mar 1, 2023
ntsekouras pushed a commit that referenced this pull request Mar 1, 2023
@oandregal @ntsekouras
Fix typo: use WP_Theme_JSON_Gutenberg instead of WP_Theme_JSON class …
cdf2da5 
…name (#48648)
@priethor priethor added the Backport to Gutenberg Minor Release Pull request that needs to be backported to a Gutenberg minor release label Mar 8, 2023
priethor pushed a commit that referenced this pull request Mar 8, 2023
@oandregal @priethor
Fix typo: use WP_Theme_JSON_Gutenberg instead of WP_Theme_JSON class …
6e5ad31 
…name (#48648)
@priethor
Copy link
Contributor

priethor commented Mar 8, 2023

Cherry-picked to the 15.3 branch in 6e5ad31 to resolve a breaking issue when opening the Post and Site Editors.

@priethor priethor removed the Backport to Gutenberg Minor Release Pull request that needs to be backported to a Gutenberg minor release label Mar 8, 2023
@priethor
Copy link
Contributor

priethor commented Mar 8, 2023

Released in Gutenberg 15.3.1, the issue found in 15.3.0 is solved ✅

@t-hamano t-hamano mentioned this pull request Mar 9, 2023
Closed
@Rishit30G Rishit30G mentioned this pull request Jul 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntsekouras ntsekouras ntsekouras approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

Assignees

@oandregal oandregal

Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 15.4
Development

Successfully merging this pull request may close these issues.
3 participants
@oandregal @priethor @ntsekouras