Post Featured Image: Don't display the scale control when the aspect ratio is original #48894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
the
[Block] Post Featured Image
|
Size Change: +12 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
scruffian
approved these changes
Mar 30, 2023
t-hamano
force-pushed
the
fix/post-featured-image-aspect-ratio
branch
from
e4896f0 to
fda34ca
Compare
|
@scruffian |
|
Yes, looks great thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR hides the scale control when the aspect-ratio setting of the Post Featured Image block is "Original (
auto)".Why?
When the block is first inserted, the
aspectRatiois set toundefined, so the scale control is not visible. However, if you change it to a value other than the original, and then again to the original, theautovalue will be set and the scale control will remain visible.eabdfffc5bc29b69c95d9c1f263d7de3.mp4
How?
When
aspectRatioisauto, the scale control is hidden. Or maybe it would be better to update toundefinedwhenaspectRatiois changed to "Original".Testing Instructions