Navigation: Simplify the method for finding the fallback menu #48916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Code Quality
|
Size Change: -50 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
getdave
approved these changes
Mar 8, 2023
|
Flaky tests detected in 15372a9. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4362887896
|
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
A follow-up based on #48908 (comment).
PR simplifies the method for finding the fallback navigation menu ID.
How?
fallbackNavigationMenuswithfallbackNavigationMenuId.filterwithfind. The latter stops iterating through the array whencallbackreturns a truthy value. A small perf optimiazation.Testing Instructions
Make sure there's at least one published
wp_navigationmenu item. Go to/wp-admin/edit.php?post_type=wp_navigationScreenshots or screencast
CleanShot.2023-03-08.at.13.05.49.mp4